commit: 23b0bfae026a7bbb31e544eed9b8346ef85fc610 Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Thu Feb 16 07:35:05 2023 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Sat Feb 18 10:13:34 2023 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=23b0bfae
tests: news: always check for validity of generated news item Previously, we'd ignore invalid news items in these tests because they're intended to check for the respective 'relevance' field. Fix that. Bug: https://bugs.gentoo.org/889330 Signed-off-by: Sam James <sam <AT> gentoo.org> lib/portage/tests/news/test_NewsItem.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/portage/tests/news/test_NewsItem.py b/lib/portage/tests/news/test_NewsItem.py index fcfc06b13..ba912a525 100644 --- a/lib/portage/tests/news/test_NewsItem.py +++ b/lib/portage/tests/news/test_NewsItem.py @@ -139,6 +139,7 @@ class NewsItemTestCase(TestCase): item = self._processItem(str(tmpItem)) try: + self.assertTrue(item.isValid()) self.assertTrue( item.isRelevant(self.vardb, self.settings, self.profile), msg=f"Expected {tmpItem} to be relevant, but it was not!", @@ -151,6 +152,7 @@ class NewsItemTestCase(TestCase): try: item = self._processItem(str(tmpItem)) + self.assertTrue(item.isValid()) self.assertTrue( item.isRelevant(self.vardb, self.settings, self.profile), msg=f"Expected {tmpItem} to be relevant, but it was not!", @@ -163,6 +165,7 @@ class NewsItemTestCase(TestCase): try: item = self._processItem(str(tmpItem)) + self.assertTrue(item.isValid()) self.assertTrue( item.isRelevant(self.vardb, self.settings, self.profile), msg=f"Expected {tmpItem} to be relevant, but it was not!",
