commit: 4cc3e2d39a39b422074de49e88261cdf717292d5 Author: Hanno Böck <hanno <AT> gentoo <DOT> org> AuthorDate: Mon Apr 24 14:03:28 2023 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Sat Apr 29 04:41:18 2023 +0000 URL: https://gitweb.gentoo.org/proj/portage.git/commit/?id=4cc3e2d3
dispatch-conf: Avoid race when accessing log file First creating the file and then running chmod creates a security risk where a user could access the file. Avoid this by enforcing the file permissions via umask. Signed-off-by: Hanno Böck <hanno <AT> gentoo.org> Closes: https://github.com/gentoo/portage/pull/1025 Signed-off-by: Sam James <sam <AT> gentoo.org> bin/dispatch-conf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bin/dispatch-conf b/bin/dispatch-conf index 3dbfb0ed6..154b26ff5 100755 --- a/bin/dispatch-conf +++ b/bin/dispatch-conf @@ -119,8 +119,9 @@ class dispatch: if os.path.isfile(self.options["log-file"]) or not os.path.exists( self.options["log-file"] ): + old_umask = os.umask(0o077) open(self.options["log-file"], "w").close() # Truncate it - os.chmod(self.options["log-file"], 0o600) + os.umask(old_umask) pager = self.options.get("pager") if pager is None or not cmd_var_is_valid(pager):
