commit: dc6a83ceb069a6c50b82251638ae024dbd0339a0 Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Fri May 19 00:55:13 2023 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Fri May 19 00:56:32 2023 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dc6a83ce
toolchain.eclass: return to using -j1 for make install Unfortunately, we have to use -j1 for make install. Upstream don't really test it and there's not much appetite for fixing bugs with it. Several reported bugs exist where the resulting image was wrong, rather than a simple compile/install failure: This reverts commit db0387530cf744068f480b68a192d4fc10a81286. Closes: https://bugs.gentoo.org/906155 Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42980 Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51814 Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103656 Bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109898 Signed-off-by: Sam James <sam <AT> gentoo.org> eclass/toolchain.eclass | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass index ea6ba797036f..36369bb8d193 100644 --- a/eclass/toolchain.eclass +++ b/eclass/toolchain.eclass @@ -2113,7 +2113,7 @@ toolchain_src_install() { # # Do the 'make install' from the build directory pushd "${WORKDIR}"/build-jit > /dev/null || die - S="${WORKDIR}"/build-jit emake DESTDIR="${D}" install + S="${WORKDIR}"/build-jit emake DESTDIR="${D}" -j1 install # Punt some tools which are really only useful while building gcc find "${ED}" -name install-tools -prune -type d -exec rm -rf "{}" \; @@ -2127,7 +2127,17 @@ toolchain_src_install() { fi # Do the 'make install' from the build directory - S="${WORKDIR}"/build emake DESTDIR="${D}" install + # + # Unfortunately, we have to use -j1 for make install. Upstream + # don't really test it and there's not much appetite for fixing bugs + # with it. Several reported bugs exist where the resulting image + # was wrong, rather than a simple compile/install failure: + # - bug #906155 + # - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42980 + # - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=51814 + # - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103656 + # - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109898 + S="${WORKDIR}"/build emake DESTDIR="${D}" -j1 install # Punt some tools which are really only useful while building gcc find "${ED}" -name install-tools -prune -type d -exec rm -rf "{}" \;
