commit: 95c30c376450b77f7f6f12c84589c26badc149b0 Author: Eli Schwartz <eschwartz93 <AT> gmail <DOT> com> AuthorDate: Wed Oct 11 04:59:53 2023 +0000 Commit: Zac Medico <zmedico <AT> gentoo <DOT> org> CommitDate: Wed Oct 18 04:26:02 2023 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=95c30c37
app-text/calibre: document reason for Qt slotting, and correct a bad one Per https://wiki.gentoo.org/wiki/Project:Qt/Policies#Dependencies we should not be using := unless we build against the Qt private API. As it happens, we do. But also as it happens, we ended up slotting all dependencies (other than the one I just added), whereas one of them was not needed as it is only linked to via a compiled extension that doesn't use private API. Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com> Signed-off-by: Zac Medico <zmedico <AT> gentoo.org> app-text/calibre/calibre-5.44.0-r2.ebuild | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app-text/calibre/calibre-5.44.0-r2.ebuild b/app-text/calibre/calibre-5.44.0-r2.ebuild index b47c8eb32888..46dfe4477827 100644 --- a/app-text/calibre/calibre-5.44.0-r2.ebuild +++ b/app-text/calibre/calibre-5.44.0-r2.ebuild @@ -41,6 +41,8 @@ IUSE="ios +udisks" REQUIRED_USE="${PYTHON_REQUIRED_USE}" +# Qt slotted dependencies are used because the libheadless.so plugin links to +# QT_*_PRIVATE_ABI. It only uses core/gui/dbus. COMMON_DEPEND="${PYTHON_DEPS} >=app-text/hunspell-1.7:= >=app-text/podofo-0.9.6_pre20171027:= @@ -89,7 +91,7 @@ COMMON_DEPEND="${PYTHON_DEPS} dev-qt/qtcore:5= dev-qt/qtdbus:5= dev-qt/qtgui:5=[jpeg] - dev-qt/qtwidgets:5= + dev-qt/qtwidgets:5 dev-util/desktop-file-utils dev-util/gtk-update-icon-cache media-fonts/liberation-fonts
