commit: f2059605a643678ff4c26bd8104140281360c47a Author: Sam James <sam <AT> gentoo <DOT> org> AuthorDate: Tue Mar 26 23:40:01 2024 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Tue Mar 26 23:40:01 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2059605
sys-apps/coreutils: fully skip tty-eof.pl It's an unreliable/flaky test, not just a known failure, so XFAIL isn't appropriate as it may pass sometimes -> unexpected XPASS. tdr reported this passed for him which is how I noticed my silly error. Bug: https://bugs.gentoo.org/910640 Signed-off-by: Sam James <sam <AT> gentoo.org> sys-apps/coreutils/coreutils-9.4-r1.ebuild | 9 ++++++--- sys-apps/coreutils/coreutils-9.4.ebuild | 9 ++++++--- sys-apps/coreutils/coreutils-9.4_p20240323.ebuild | 9 ++++++--- sys-apps/coreutils/coreutils-9999.ebuild | 9 ++++++--- 4 files changed, 24 insertions(+), 12 deletions(-) diff --git a/sys-apps/coreutils/coreutils-9.4-r1.ebuild b/sys-apps/coreutils/coreutils-9.4-r1.ebuild index adf51c2bed02..bb3b8847f239 100644 --- a/sys-apps/coreutils/coreutils-9.4-r1.ebuild +++ b/sys-apps/coreutils/coreutils-9.4-r1.ebuild @@ -244,11 +244,14 @@ src_test() { # We have a patch which fixes this (bug #259876) #tests/touch/not-owner #tests/touch/not-owner.sh - - # bug #910640 - tests/tty/tty-eof.pl ) + # This test is flaky (bug #910640). + cat > tests/tty/tty-eof.pl <<-EOF || die + #!/usr/bin/perl + exit 77; + EOF + # We set DISABLE_HARD_ERRORS because some of the tests hard error-out # because of sandbox. They're skipped above but DISABLE_HARD_ERRORS is needed # to downgrade them to FAIL. diff --git a/sys-apps/coreutils/coreutils-9.4.ebuild b/sys-apps/coreutils/coreutils-9.4.ebuild index 4c826357e157..7f7d258299b7 100644 --- a/sys-apps/coreutils/coreutils-9.4.ebuild +++ b/sys-apps/coreutils/coreutils-9.4.ebuild @@ -242,11 +242,14 @@ src_test() { # We have a patch which fixes this (bug #259876) #tests/touch/not-owner #tests/touch/not-owner.sh - - # bug #910640 - tests/tty/tty-eof.pl ) + # This test is flaky (bug #910640). + cat > tests/tty/tty-eof.pl <<-EOF || die + #!/usr/bin/perl + exit 77; + EOF + # We set DISABLE_HARD_ERRORS because some of the tests hard error-out # because of sandbox. They're skipped above but DISABLE_HARD_ERRORS is needed # to downgrade them to FAIL. diff --git a/sys-apps/coreutils/coreutils-9.4_p20240323.ebuild b/sys-apps/coreutils/coreutils-9.4_p20240323.ebuild index 95bb5424c9b2..66cc53b9133f 100644 --- a/sys-apps/coreutils/coreutils-9.4_p20240323.ebuild +++ b/sys-apps/coreutils/coreutils-9.4_p20240323.ebuild @@ -241,11 +241,14 @@ src_test() { # We have a patch which fixes this (bug #259876) #tests/touch/not-owner #tests/touch/not-owner.sh - - # bug #910640 - tests/tty/tty-eof.pl ) + # This test is flaky (bug #910640). + cat > tests/tty/tty-eof.pl <<-EOF || die + #!/usr/bin/perl + exit 77; + EOF + # We set DISABLE_HARD_ERRORS because some of the tests hard error-out # because of sandbox. They're skipped above but DISABLE_HARD_ERRORS is needed # to downgrade them to FAIL. diff --git a/sys-apps/coreutils/coreutils-9999.ebuild b/sys-apps/coreutils/coreutils-9999.ebuild index 95bb5424c9b2..66cc53b9133f 100644 --- a/sys-apps/coreutils/coreutils-9999.ebuild +++ b/sys-apps/coreutils/coreutils-9999.ebuild @@ -241,11 +241,14 @@ src_test() { # We have a patch which fixes this (bug #259876) #tests/touch/not-owner #tests/touch/not-owner.sh - - # bug #910640 - tests/tty/tty-eof.pl ) + # This test is flaky (bug #910640). + cat > tests/tty/tty-eof.pl <<-EOF || die + #!/usr/bin/perl + exit 77; + EOF + # We set DISABLE_HARD_ERRORS because some of the tests hard error-out # because of sandbox. They're skipped above but DISABLE_HARD_ERRORS is needed # to downgrade them to FAIL.
