commit:     8398394c8cd9b13fa675805b8b4349d9645e2883
Author:     Eli Schwartz <eschwartz93 <AT> gmail <DOT> com>
AuthorDate: Mon Apr  8 21:46:52 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Tue Apr  9 14:43:14 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8398394c

sci-geosciences/opencpn: remove mysterious double-eapply

In multiple phase functions, "default" is run in addition to cmake_*
eclass phases. This is entirely redundant, as cmake.eclass does this for
you. As a result, running it twice would simply attempt to apply a patch
that has already been applied, inevitably failing, and causing a very
confusing build error when you know the patch does indeed apply.

Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 sci-geosciences/opencpn/opencpn-5.8.4.ebuild | 2 --
 1 file changed, 2 deletions(-)

diff --git a/sci-geosciences/opencpn/opencpn-5.8.4.ebuild 
b/sci-geosciences/opencpn/opencpn-5.8.4.ebuild
index 816c23d16687..694939aded12 100644
--- a/sci-geosciences/opencpn/opencpn-5.8.4.ebuild
+++ b/sci-geosciences/opencpn/opencpn-5.8.4.ebuild
@@ -46,7 +46,6 @@ BDEPEND="
        "
 
 src_prepare() {
-       default
        # see bug #907759
        sed -i "s/ cc / $(tc-getBUILD_CC) /" "${S}"/CMakeLists.txt
        cmake_src_prepare
@@ -72,7 +71,6 @@ src_configure() {
 }
 
 src_install() {
-       default
        cmake_src_install
        mv "${D}/usr/share/doc/${PN}"/* "${D}/usr/share/doc/${PF}" || die
        rmdir "${D}/usr/share/doc/${PN}"

Reply via email to