commit:     7eea00cab392d029ac574c691fa0149b77c743f4
Author:     Eli Schwartz <eschwartz93 <AT> gmail <DOT> com>
AuthorDate: Sun May  5 04:52:03 2024 +0000
Commit:     Sam James <sam <AT> gentoo <DOT> org>
CommitDate: Sun May  5 11:47:11 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7eea00ca

media-libs/liblo: replace useless sed with configure option

 * SED: the following did not cause any changes
 *     sed -i '/^SUBDIRS =/s/examples//' Makefile.am || die;
 * no-op: -e /^SUBDIRS =/s/examples//

In 2014, the Makefile.am was reworked (in version 0.29):
https://sourceforge.net/p/liblo/git/ci/02f7754e245080626a590e43c190dfd4abe0d72f/

This was a side effect of making it into a configure option, which means
patching is no longer needed.

As a result, the intended goal of this sed hasn't worked for a decade --
the examples were compiled by portage and then discarded as they aren't
installed. It is "just" wasted work. But we can avoid that...

Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com>
Signed-off-by: Sam James <sam <AT> gentoo.org>

 media-libs/liblo/liblo-0.32.ebuild | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/media-libs/liblo/liblo-0.32.ebuild 
b/media-libs/liblo/liblo-0.32.ebuild
index b5b1eaac6230..26f501ffc99b 100644
--- a/media-libs/liblo/liblo-0.32.ebuild
+++ b/media-libs/liblo/liblo-0.32.ebuild
@@ -24,9 +24,6 @@ PATCHES=(
 src_prepare() {
        default
 
-       # don't build examples by default
-       sed -i '/^SUBDIRS =/s/examples//' Makefile.am || die
-
        eautoreconf
 }
 
@@ -35,6 +32,8 @@ src_configure() {
 
        # switching threads on/off breaks ABI, bugs #473282, #473286 and #473356
        local myeconfargs=(
+               # don't build examples by default
+               --disable-examples
                --enable-threads
                --disable-network-tests
                $(use_enable test tests)

Reply via email to