commit:     d5e060a2d9ae439620689acc720d9a11a859a3a1
Author:     Michał Górny <mgorny <AT> gentoo <DOT> org>
AuthorDate: Fri May 17 13:09:44 2024 +0000
Commit:     Michał Górny <mgorny <AT> gentoo <DOT> org>
CommitDate: Mon May 20 16:56:46 2024 +0000
URL:        https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d5e060a2

python-utils-r1.eclass: Fix cleanup in failing epytest

Fix epytest to call `die -n` after performing the cleanup, rather than
before.  This ensures that stray cache files are cleaned up even if
we're actually going to die, e.g. when using
`FEATURES=test-fail-continue`.

Signed-off-by: Michał Górny <mgorny <AT> gentoo.org>
Closes: https://github.com/gentoo/gentoo/pull/36672
Signed-off-by: Michał Górny <mgorny <AT> gentoo.org>

 eclass/python-utils-r1.eclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/eclass/python-utils-r1.eclass b/eclass/python-utils-r1.eclass
index 584ed831f816..c47565fa1db2 100644
--- a/eclass/python-utils-r1.eclass
+++ b/eclass/python-utils-r1.eclass
@@ -1444,7 +1444,7 @@ epytest() {
        set -- "${EPYTHON}" -m pytest "${args[@]}" "${@}" ${EPYTEST_FLAGS}
 
        echo "${@}" >&2
-       "${@}" || die -n "pytest failed with ${EPYTHON}"
+       "${@}"
        local ret=${?}
 
        # remove common temporary directories left over by pytest plugins
@@ -1455,6 +1455,7 @@ epytest() {
                find "${BUILD_DIR}" -name '*-pytest-*.pyc' -delete || die
        fi
 
+       [[ ${ret} -ne 0 ]] && die -n "pytest failed with ${EPYTHON}"
        return ${ret}
 }
 

Reply via email to