commit: 7dacecf376120d114419b41885bcfa01ed1d981e Author: Eli Schwartz <eschwartz93 <AT> gmail <DOT> com> AuthorDate: Sun May 26 22:17:49 2024 +0000 Commit: Sam James <sam <AT> gentoo <DOT> org> CommitDate: Sun May 26 23:11:05 2024 +0000 URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7dacecf3
dev-debug/valgrind: add whitelist for false positive configure implicit decls The issue here is, yet again, that clang is a trash compiler and cannot handle sensible diagnostic output. It warns you for implicit function decls because it doesn't permit nested function definitions, *after* it tells you that it doesn't permit the nested function. Instead of just telling you that the former is forbidden. Closes: https://bugs.gentoo.org/900396 Signed-off-by: Eli Schwartz <eschwartz93 <AT> gmail.com> Signed-off-by: Sam James <sam <AT> gentoo.org> dev-debug/valgrind/valgrind-3.22.0-r2.ebuild | 7 +++++++ dev-debug/valgrind/valgrind-3.23.0.ebuild | 7 +++++++ dev-debug/valgrind/valgrind-9999.ebuild | 7 +++++++ 3 files changed, 21 insertions(+) diff --git a/dev-debug/valgrind/valgrind-3.22.0-r2.ebuild b/dev-debug/valgrind/valgrind-3.22.0-r2.ebuild index b9204af91b7b..86ec190689c8 100644 --- a/dev-debug/valgrind/valgrind-3.22.0-r2.ebuild +++ b/dev-debug/valgrind/valgrind-3.22.0-r2.ebuild @@ -53,6 +53,13 @@ PATCHES=( "${FILESDIR}"/0004-Bug-478624-Valgrind-incompatibility-with-binutils-2..patch ) +QA_CONFIG_IMPL_DECL_SKIP+=( + # "checking if gcc accepts nested functions" but clang cannot handle good + # errors and reports both "function definition is not allowed here" and + # -Wimplicit-function-declaration. bug #900396 + foo +) + src_prepare() { # Correct hard coded doc location sed -i -e "s:doc/valgrind:doc/${PF}:" docs/Makefile.am || die diff --git a/dev-debug/valgrind/valgrind-3.23.0.ebuild b/dev-debug/valgrind/valgrind-3.23.0.ebuild index efcec418f726..48014039f07e 100644 --- a/dev-debug/valgrind/valgrind-3.23.0.ebuild +++ b/dev-debug/valgrind/valgrind-3.23.0.ebuild @@ -55,6 +55,13 @@ PATCHES=( # From stable branch ) +QA_CONFIG_IMPL_DECL_SKIP+=( + # "checking if gcc accepts nested functions" but clang cannot handle good + # errors and reports both "function definition is not allowed here" and + # -Wimplicit-function-declaration. bug #900396 + foo +) + src_prepare() { # Correct hard coded doc location sed -i -e "s:doc/valgrind:doc/${PF}:" docs/Makefile.am || die diff --git a/dev-debug/valgrind/valgrind-9999.ebuild b/dev-debug/valgrind/valgrind-9999.ebuild index efcec418f726..48014039f07e 100644 --- a/dev-debug/valgrind/valgrind-9999.ebuild +++ b/dev-debug/valgrind/valgrind-9999.ebuild @@ -55,6 +55,13 @@ PATCHES=( # From stable branch ) +QA_CONFIG_IMPL_DECL_SKIP+=( + # "checking if gcc accepts nested functions" but clang cannot handle good + # errors and reports both "function definition is not allowed here" and + # -Wimplicit-function-declaration. bug #900396 + foo +) + src_prepare() { # Correct hard coded doc location sed -i -e "s:doc/valgrind:doc/${PF}:" docs/Makefile.am || die
