On Sat, 26 Feb 2005 15:39:07 -0500 Lina Pezzella <[EMAIL PROTECTED]> wrote: | On Feb 26, 2005, at 3:27 PM, Ciaran McCreesh wrote: | > On Sat, 26 Feb 2005 15:17:29 -0500 Lina Pezzella <[EMAIL PROTECTED]> | > wrote: | > | On Feb 26, 2005, at 1:58 PM, Ciaran McCreesh wrote: | > | > Didn't we decide that arch specific patches were a bad idea? | > | | > | I hope not; there are plenty of archs that need arch-specific | > patches. | > | > Isn't this why we have #ifdef and autotools? | | Okay. So next time I have to patch 10 files for ppc-macos only, I | should make #ifdefs, patch those 10 files in global scope and force | everyone else to patch unnecessarily. I think not.
Well, you're sending all your patches upstream, right? There's no way upstream can conditionally apply patches to their source, so they'll *have* to use autotools (or the equivalent for whatever language that is, but I'd imagine most of these are C things...). Sending them complete patches, rather than ones that will break non-macos, is just a matter of politeness. -- Ciaran McCreesh : Gentoo Developer (Vim, Fluxbox, shell tools) Mail : ciaranm at gentoo.org Web : http://dev.gentoo.org/~ciaranm
pgpe4K77XoVOR.pgp
Description: PGP signature
