On Tuesday 12 April 2005 02:20 pm, Maurice van der Pot wrote:
> On Tue, Apr 12, 2005 at 01:52:05PM -0400, Mike Frysinger wrote:
> > On Tuesday 12 April 2005 11:59 am, Maurice van der Pot wrote:
> > > I have the following situation:
> > > - a package (valgrind) that can be compiled with PIE and uses PIE
> > > for some purpose or other if it is supported
> > > - tests (make check) that cannot be compiled with PIE
> >
> > allowing user specified tests for `make check` doesnt really make much
> > sense
>
> 'user specified tests'?? The tests are part of valgrind, they just can't
> be compiled with PIE.
err s/tests/CFLAGS/
> > and in fact it's probably a better idea to prevent user CFLAGS from being
> > used during `make check`
>
> In theory, you're probably right. But would you really spend time on
> disabling user CFLAGS for make check?
why not ? you've just shown they break things
src_test() { make check CFLAGS="" || die "make check failed" ; }
> How many ebuilds are doing this right now anyway?
how many ebuilds' src_test are sensitive user CFLAGS ? very few i'd say
-mike
--
gentoo-dev@gentoo.org mailing list
