On Fri Oct 17, 2025 at 9:04 AM BST, Petr Vaněk wrote: > Hi, > > just two small nitpicks related to refpolicy_types.desc: > > On Thu, Oct 16, 2025 at 09:56:06PM +0100, Rahul Sandhu wrote: >> diff --git a/profiles/desc/refpolicy_types.desc >> b/profiles/desc/refpolicy_types.desc >> new file mode 100644 >> index 000000000..6cd4b2ba0 >> --- /dev/null >> +++ b/profiles/desc/refpolicy_types.desc >> @@ -0,0 +1,10 @@ >> +# Copyright 2007-2025 Gentoo Authors > > I think the copyright should be set to 2025 only, for new file.
Sure, will update that. > >> +# Distributed under the terms of the GNU General Public License v2 >> + >> +# This file contains descriptions of REFPOLICY_TYPES USE_EXPAND flags. >> + >> +# Keep it sorted. >> +targeted - Targeted policy >> +strict - Strict policy >> +mcs - Multi-Category Security policy >> +mls - Multi-Level Security policy > > The comment says keep it sorted but the list is not sorted. I copied that comment from the apache mods desc file, and the flags looked sorted to me as I'm used to seeing policy types in that specific order - whoops! I'll just drop the comment them, because I'd rather have the flags be consistent with the ordering we use everywhere else, unless there are any specific reasons or concerns to specifically keep the flags alphabetically ordered. > > Cheers, > Petr
