On Thu, Jan 01, 2026 at 09:03:18PM +0500, zyxhere💠wrote: > On Mon, 2025-12-15 at 16:01 +0000, James Le Cuirot wrote: > > Signed-off-by: James Le Cuirot <[email protected]> > > --- > > eclass/branding.eclass | 85 ++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 85 insertions(+) > > create mode 100644 eclass/branding.eclass > > > > diff --git a/eclass/branding.eclass b/eclass/branding.eclass > > new file mode 100644 > > index 000000000000..06b09f09ea4c > > --- /dev/null > > +++ b/eclass/branding.eclass > > @@ -0,0 +1,85 @@ > > +# Copyright 2025 Gentoo Authors > > +# Distributed under the terms of the GNU General Public License v2 > > + > > +# @ECLASS: branding.eclass > > +# @MAINTAINER: > > +# James Le Cuirot <[email protected]> > > +# @AUTHOR: > > +# James Le Cuirot <[email protected]> > > +# @SUPPORTED_EAPIS: 8 9 > > +# @BLURB: Branding variables with Gentoo defaults > > +# @DESCRIPTION: > > +# This defines a set of variables for appling branding to various > > packages. The > > +# variables default to Gentoo values. These can be overridden by users or > > +# downstream distributions. > > + > > +case ${EAPI} in > > + 8|9) ;; > > + *) die "${ECLASS}: EAPI ${EAPI:-0} not supported" ;; > > +esac > > + > > +# @ECLASS_VARIABLE: OS_NAME > > +# @USER_VARIABLE > > +# @OUTPUT_VARIABLE > > +# @DESCRIPTION: > > +# Corresponds to os-release's NAME. See man os-release. > > +: ${OS_NAME:="Gentoo"} > > + > > +# @ECLASS_VARIABLE: OS_ID > > +# @USER_VARIABLE > > +# @OUTPUT_VARIABLE > > +# @DESCRIPTION: > > +# Corresponds to os-release's ID. See man os-release. > > +: ${OS_ID:="gentoo"} > > + > > +# @ECLASS_VARIABLE: OS_ID_LIKE > > +# @USER_VARIABLE > > +# @OUTPUT_VARIABLE > > +# @DEFAULT_UNSET > > +# @DESCRIPTION: > > +# Corresponds to os-release's ID_LIKE. See man os-release. > > + > > +# @ECLASS_VARIABLE: OS_HOME_URL > > +# @USER_VARIABLE > > +# @OUTPUT_VARIABLE > > +# @DESCRIPTION: > > +# Corresponds to os-release's HOME_URL. See man os-release. > > +: ${OS_HOME_URL:="https://www.gentoo.org/"} > > Minor nitpick maybe don't have the trailing / so just > https://www.gentoo.org looks better IMO
Think that's suggestive, personally always prefer trailing / which makes URLs clearer that they're not opening a path to a file but rather opening a directory with whatever is default. Much like how e.g. cd /usr/sh<tab> results in /usr/share/ I think it also looks better in a opening/closing way together with the https://. In general it'd be good to be consistent and use the same way everywhere (incl. websites, etc...), albeit I imagine we have some of both as-is and looking will be inconclusive. os-release had the trailing / anyway, we may as well not introduce changes here as it's not the goal of the eclass. fwiw if I open https://www.gentoo.org w/o the trailing / with curl -v or use my browser (qutebrowseR), the trailing / is automatically added so I guess it may be the more "expected" way? curl -v https://www.gentoo.org * [HTTP/2] [1] OPENED stream for https://www.gentoo.org/ -- ionen
signature.asc
Description: PGP signature
