-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Harald van D?k wrote:
> The only flags that are actually removed are the flags that are invalid
> _by themselves_. There are cases where flags are valid because of other
> flags, such as anything following -X*.
>
> Two other problems I see with the code:
> CFLAGS=${CFLAGS//bad-flag} is in the ebuild quiz, if I recall correctly.
> It's broken because it also removes valid flags that happen to contain
> bad-flag as a substring.
> Locale isn't forced to C, which means gcc may not spit out 'unrecognized
> option' at all even for invalid flags.

There is a new version at http://dev.gentoo.org/~chutzpah/profile.bashrc that
should fix all these possible problems. Thanks for pointing them out, let me
know if you see anything else.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)

iD8DBQFEP+A9Wt/XSf2CZdkRArP3AKCZZQd7V7oBTsQnxzBMDXX9VGnxpQCbBm4l
vr359Gk/O0NPPk2/2CnUPw8=
=3HQj
-----END PGP SIGNATURE-----
-- 
gentoo-dev@gentoo.org mailing list

Reply via email to