On Mon, Jul 17, 2006 at 06:00:04PM -0400, Mike Frysinger wrote: > at this point i'm against it due to the loss of information/granularity in > the > die message ... and utilizing DIE_MSG is garbage > > if die can be made more useful, then i'd be for the do* functions calling die > for me > -mike
How about changing the internals of dobin etc to behave like this (puesdo-code): in ebuild: dobin xyz in dobin code: (existing stuff) [ (check failure) ] && die "Failure: dobin $@" So if 'dobin xyz' fails, you get a die, with the message of "Failure: dobin xyz" This hooks nicely into the existing stacktrace: !!! ERROR: dev-lang/php-5.1.4-r1 failed. Call stack: ebuild.sh, line XXX: Called dyn_install ebuild.sh, line XXX: Called src_install php-5.1.4-r1.ebuild, line XXX: Called php5_1-sapi_src_install php5_1-sapi.eclass, line XXX: Called dobin dobin, line XXX: called die Additionally, keep DIE_MSG support for anybody that wants to override the default messages. -- Robin Hugh Johnson E-Mail : [EMAIL PROTECTED] GnuPG FP : 11AC BA4F 4778 E3F6 E4ED F38E B27B 944E 3488 4E85
pgphvvTy5KWjU.pgp
Description: PGP signature
