Marien Zwart wrote:
> On Thu, Mar 08, 2007 at 11:19:20AM -0600, Jim Ramsay wrote:
> > gkrellm-plugin_pkg_setup() {
> > if ! built_with_use app-admin/gkrellm X && \
> > ! has X ${IUSE}; then
> > eerror "This plugin requires the X frontend of
> > gkrellm." eerror "Please re-emerge app-admin/gkrellm with USE=\"X\""
> > die "Please re-emerge app-admin/gkrellm with
> > USE=\"X\"" fi
> > }
>
> Any chance of plugins existing (or appearing in the future) that work
> with a USE=-X gkrellm and a USE=X gkrellm the same way? In that case
> that check will not do the right thing. Perhaps add a var the plugin
> ebuild can set to indicate it does not need gkrellm built with X even
> though the plugin has no X USE flag?
>
> This will also error out if you try to build a plugin that has the X
> USE flag with both the plugin and gkrellm itself built with -X, you
> probably meant to check for "use X" too?Well, my intention was that such a plugin would do its own built_with_use checking, but I see your point, and I think that having a "Don't check for X" variable the ebuild can optionally set would be a better approach than mine - That way such an ebuild could do its own magic based on 'built_with_use gkrellm X' without having to have IUSE="X". Thanks! -- Jim Ramsay Gentoo/Linux Developer (rox,gkrellm)
signature.asc
Description: PGP signature
