-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hans de Graaff wrote:
> I'm about to commit two new eclasses to support the compilation,
> The eclasses have been in the Emacs overlay for some time now in support
> of the forthcoming app-xemacs/gentoo-syntax package:
> 
> http://overlays.gentoo.org/proj/emacs/browser/emacs-overlay/eclass/xemacs-elisp.eclass

I think it would be good to add a string argument to the call to die on line 22.

> http://overlays.gentoo.org/proj/emacs/browser/emacs-overlay/eclass/xemacs-elisp-common.eclass

You use $* and $@ here which are the same when unquoted. They should probably
be quoted and that means that all instances would become the four characters 
"$@".

Marijn

- --
Marijn Schouten (hkBst), Gentoo Lisp project
<http://www.gentoo.org/proj/en/lisp/>, #gentoo-lisp on FreeNode
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG4nP2p/VmCx0OL2wRAuSDAJ4zq1I35NKJDWc6VBkb48NODfsoGgCfTkpI
ZpQqOsjF5BjItbN+Ymuh1vU=
=KF2I
-----END PGP SIGNATURE-----
-- 
[EMAIL PROTECTED] mailing list

Reply via email to