On Saturday 15 September 2007, Donnie Berkholz wrote:
> On 16:52 Sat 15 Sep     , Mike Frysinger wrote:
> > On Saturday 15 September 2007, Donnie Berkholz wrote:
> > > On 05:56 Sat 15 Sep     , Mike Frysinger wrote:
> > > > On Saturday 15 September 2007, Donnie Berkholz wrote:
> > > > > Also, try using { } around a block of code instead of ( ), which
> > > > > creates a subshell.
> > > >
> > > > erm, what ?  () is a subshell, {} is a list of grouped commands ...
> > >
> > > Right, that's what I said. What's the point of using a subshell here?
> > > That comment about environment pollution didn't make sense to me.
> >
> > the "into" part pollutes the environment
>
> One insinto definitely doesn't qualify as pollution to me. Mild
> littering, perhaps. But with a subshell, it's only a matter of time
> before something weird happens, like trying to put a die() in there.

i dont use the eclass so it doesnt matter to me, but it does modify the 
environment in possibly unexpected ways for the caller

for do* funcs this is a must, for other funcs it's up to the maintainers
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to