On Montag, 24. September 2007, Donnie Berkholz wrote:
> On 19:59 Mon 24 Sep , Matthias Schwarzott (zzam) wrote:
> > zzam 07/09/24 19:59:38
> >
>
> This ebuild has really inconsistent use of tests, quotes in tests, and
> command substitutions. Being more consistent will increase readability
> and decrease bugs due to differences between styles. For tests, pick a
> style [[ ]] or [ ] and stick with it. The [[ ]] one is pretty nice
> because it generally doesn't require quotes, so the code looks a lot
> cleaner. For command substitions, prefer $() over ``.
>
> > newins ${FILESDIR}/blacklist-110 blacklist
> > doins ${FILESDIR}/pnp-aliases
>
> Quotes here.
>
> > emake \
> > EXTRAS="${extras}" \
> > libudevdir=${udev_helper_dir} \
> > CROSS_COMPILE=${mycross} \
> > OPTFLAGS="" \
> > ${myconf} || die
> >
> > emake \
> > DESTDIR="${D}" \
> > libudevdir=${udev_helper_dir} \
> > EXTRAS="${extras}" \
> > ${myconf} \
> > install || die
>
> Could use some die messages here.
>
> Thanks,
> Donnie
fixed, thanks
Matthias
--
Matthias Schwarzott (zzam)
--
[EMAIL PROTECTED] mailing list
