Mike Frysinger wrote: > On Wednesday 26 September 2007, Donnie Berkholz wrote: > >> On 16:11 Wed 26 Sep , Mike Frysinger wrote: >> >>> On Wednesday 26 September 2007, Christian Faulhammer wrote: >>> >>>> Joe Peterson <[EMAIL PROTECTED]>: >>>> >>>>> Thanks for the tip. I added "failed to install genlop (via dobin)" - >>>>> not sure if there is a standard way to do this, as it seems many >>>>> ebuilds just do "dobin failed", and some do "failed to install ...". >>>>> >>>> It is mainly to localise which die command caused the halt. So I know >>>> of no standard. >>>> >>> if there is just one call to die in a function, then i usually dont >>> bother ... but if there are multiple ones (possibly nested), then it can >>> easily save time >>> >> Cardoe was just telling me that die messages are not that useful or >> time-saving because portage posts the line number of the failure >> already. >> > > true, since portage has added this traceback feature (it hasnt always been > there), the need for the message has decreased ... i want to say however that > it still isnt 100% correct in some nested situations, but i may be > remembering things wrong or outdated ... > I thought these issues were worked out already?
> also, ebuilds do change over time, so what line # may be correct one day may > not be relevant the next ... > True. I will concede this point. I could attempt to argue this is why it's important to know the version and revision of the package you are emerging. But the counter point is evident, times when the ebuild is changed without a bump pose a problem. Which could bring up a point of would it be useful to see if we can print out the actual line that caused the die. Now, I don't know if this feasible or something the Portage devs want to do. But again, in the effort to streamline this might be something to consider. > >> That prompts the question, should we get rid of die messages? >> > > perhaps de-emphasize their general worth, but not get rid of them > -mike > Which is what I'm after. Let's not force people to put a pointless message in there if it's going to be pointless. Essentially, the argument here is let's be consistent and put a message always. But a better plan of action is let's use common sense and add it as needed. -- [EMAIL PROTECTED] mailing list
