[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-video/vdr: ChangeLog vdr-1.4.7-r5.ebuild

[Donnie Berkholz]

On 12:40 Sun 30 Sep     , Matthias Schwarzott (zzam) wrote:
> 1.1                  media-video/vdr/vdr-1.4.7-r5.ebuild
> 
> file : 
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/vdr/vdr-1.4.7-r5.ebuild?rev=1.1&view=markup
> plain: 
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/media-video/vdr/vdr-1.4.7-r5.ebuild?rev=1.1&content-type=text/plain

> add_cap() {
>       while [ "$1" ]; do
>               CAPS="${CAPS}\n$1=1"
>               shift
>       done
> }
> 
> enable_patch() {
>       local patch
>       while [ "$1" ]; do
>               patch="$1"
>               echo "$patch = 1" >> Make.config
>               shift
>       done
> }

This is a really strange idiom. Why not do something like:

for arg in "$@"; do
        CAPS="${CAPS}\n${arg}=1"
done

for arg in "$@"; do
        echo "$arg = 1" >> Make.config
done

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list