On 9/30/07, Mike Frysinger <[EMAIL PROTECTED]> wrote:
> On Sunday 30 September 2007, Zac Medico wrote:
> > Donnie Berkholz wrote:
> > > On 04:52 Sat 29 Sep     , Mike Frysinger wrote:
> > >> does this work with multilines ?
> > >> if [[ -e ${S}/asdfasdfasdf && \
> > >>    -f ${WORKDIR}/moo ]]
> > >> then
> > >>
> > >> this is a crappy example, but entirely correct when the if statement
> > >> gets real long ...
> > >
> > > No, it doesn't. That's why I just made it a warning instead of a
> > > failure, because it's not always going to work.
> >
> > If there aren't many false positives then we don't have to reduce it
> > to a warning since they can use the new repoman --force option to
> > force the commit. If there are many false positives then I think we
> > should try to filter those out if possible so that we don't have to
> > reduce it to a warning and spam people with bogus warning messages.
>
> i see --force as something you should use in order to get around semi-serious
> (but there's a good reason for it) ... not something that people should have
> to use to get around perfectly legit code ...
>
> maybe a new function in repoman that would eat a line as the shell defines it
> (in other words, sucks in all line continuations)
> -mike

import shlex.... ;)

I've ripped out all the ebuild content checks into seperate classes
for repoman, I just need to rewrite the warn[] fail[] stuff to work
right.

-Alec
-- 
[EMAIL PROTECTED] mailing list

Reply via email to