On 04:42 Mon 01 Oct     , Steve Arnold (nerdboy) wrote:
> Revision  Changes    Path
> 1.1                  dev-java/rjava/rjava-0.5.1.ebuild
> 
> file : 
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/rjava/rjava-0.5.1.ebuild?rev=1.1&view=markup
> plain: 
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/dev-java/rjava/rjava-0.5.1.ebuild?rev=1.1&content-type=text/plain

> src_compile() {
>       export R_HOME="/usr/$(get_libdir)/R"
> 
>       # use R's check command to test package (really needs to come before
>       # the src_compile section)
>       if has test ${FEATURES}; then
>           cd ${WORKDIR}
>           R CMD check ${MY_PN}
>       fi

WORKDIR needs quotes.. Also this section is pretty weird.

>       make -f Makevars all || die "make failed"

Not emake?

>       cd ${WORKDIR}
>       cd ${S}

Quotes..

>       if [[ ! -z "`java-config --java-version | grep IBM`" ]] ; then

-n might be a bit clearer than ! -z.

>               # IBM JDK
>               JAVA_LIB_DIR="$(java-config --jdk-home)/jre/bin"
>       else
>               # Sun derived JDKs (Blackdown, Sun)
>               JAVA_LIB_DIR="$(java-config --jdk-home)/jre/lib/${jvmarch}"
>       fi

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list

Reply via email to