Mon, Oct 01, 2007 at 01:06:42AM -0700 tarihinde, Donnie Berkholz yazmış:
> On 07:46 Mon 01 Oct     , Ali Polatel (hawking) wrote:
> > 1.1                  sys-auth/pam_chroot/pam_chroot-0.9.2.ebuild
> > 
> > file : 
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-auth/pam_chroot/pam_chroot-0.9.2.ebuild?rev=1.1&view=markup
> > plain: 
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-auth/pam_chroot/pam_chroot-0.9.2.ebuild?rev=1.1&content-type=text/plain
> 
> >     LDFLAGS="$(raw-ldflags)" emake \
> >             CC="$(tc-getCC)" LD="$(tc-getLD)" || die "emake failed"
> 
> This reads really strangely to me. It's passing variables on both sides 
> of emake. Generally one would just pick a side (afterwards) and add 
> everything there.

Well, here is the related part from Makefile:

LDFLAGS  := -x --shared $(LDFLAGS)

emake LDFLAGS="$(raw-ldflags)" overrides that definition,
emake LDFLAGS="-x --shared $(raw-ldflags)" works as expected, or my
version, maybe I should add a note about it to the ebuild...

> Thanks,
> Donnie

-- 
ali polatel (hawking)

Attachment: pgpK28kFNp2U5.pgp
Description: PGP signature

Reply via email to