Steve Long <[EMAIL PROTECTED]> wrote: > >> > Mixing 'gt' and 'ge' is a bad idea. > >> > >> Just outa curiosity, why? > > > > Because it's inconsistent and one generally assumes that people will be > > consistent with the way they test numbers. That way you only need to > > read the number rather than continually checking every single line to > > see how exactly it's tested for. > > > I don't see how this is inconsistent either: two tests are needed, so that > both patches are only applied for >=2.6.22 and first only if >2.6.20.
The point is that if you stick to "ge" OR "gt", everyone could just skip reading the comparison and focus on the numbers. Will be fixed in the next release, along with kernel-2.4 support... -- Regards, Matti Bickel Signed/Encrypted email preferred (key 4849EC6C)
pgpGNkr8MFQEL.pgp
Description: PGP signature
