On Wednesday 31 October 2007, Donnie Berkholz wrote:
> On 15:38 Wed 31 Oct     , Raul Porcel (armin76) wrote:
> > 1.1                  net-p2p/deluge/deluge-0.5.6.2.ebuild
> >
> > file :
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5
> >.6.2.ebuild?rev=1.1&view=markup plain:
> > http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-p2p/deluge/deluge-0.5
> >.6.2.ebuild?rev=1.1&content-type=text/plain
> >
> > pkg_setup() {
> >     if has_version "<dev-libs/boost-1.34" && \
> >             ! built_with_use "dev-libs/boost" threads; then
> >             eerror "dev-libs/boost has to be built with threads USE-flag."
> >             die "Missing threads USE-flag for dev-libs/boost"
> >     fi
> > }
> >
> > src_compile() {
> >     filter-ldflags -Wl,--as-needed
> >
> >     distutils_src_compile
> > }
>
> If you moved the filter-ldflags() call up to pkg_setup(), you could drop
> src_compile() altogether to clean up the ebuild a little.

a better idea is to fix the problem instead of ignoring it with filter-ldflags
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to