On 14:23 Mon 05 Nov , Peter Volkov (pva) wrote:
> 1.1 net-firewall/ipset/ipset-2.3.0.20070828.ebuild
>
> file :
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-firewall/ipset/ipset-2.3.0.20070828.ebuild?rev=1.1&view=markup
> plain:
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-firewall/ipset/ipset-2.3.0.20070828.ebuild?rev=1.1&content-type=text/plain
> src_defs() {
> # these are used in both of src_compile and src_install
> myconf="${myconf} PREFIX="
> myconf="${myconf} LIBDIR=/lib"
Should this be get_libdir()?
Also seems like instead of having a function to do this, you could just
define the variables once in pkg_setup() or src_compile() as globals.
> pkg_config() {
> cd "${ROOT}${PORTAGE_TMPDIR}"
> mkdir patch-o-matic-ng
> cd patch-o-matic-ng
>
> IPTVERINS=`echo $(best_version net-firewall/iptables) | \
> sed -n
> 's:^[^/]*/[[:alpha:]]*-\([0-9]\+\([.][0-9]\+\)*[a-z]\?\(_\(pre\|p\|beta\|alpha\|rc\)[0-9]*\)*\)\(-r[0-9]\+\)\?$:\1:p'`
>
> einfo "Unpacking patch-o-matic-ng-${POM_PV}"
> tar -jxf "${DISTDIR}"/patch-o-matic-ng-${POM_PV}.tar.bz2 || \
> die "Unable to unpack
> patch-o-matic-ng-${POM_PV}"
> einfo "Unpacking iptables-${IPTVERINS}"
> tar -jxf "${DISTDIR}"/iptables-${IPTVERINS}.tar.bz2 || \
> die "Unable to unpack
> iptables-${IPTVERINS}.tar.bz2"
Could you just call unpack() here?
> einfo "Enter path to your kernel sources, relative to ${ROOT}"
> echo -n "[/usr/src/linux]: "
> read K_DIR
> [ "${ROOT}${K_DIR}" == "/" ] && K_DIR=${ROOT}/usr/src/linux
/usr/src/linux should be what's used here, and if they want to change
the kernel to affect, they should change where the symlink points
instead of having a secondary config mechanism.
Thanks,
Donnie
--
[EMAIL PROTECTED] mailing list
