On 09:42 Fri 14 Dec     , Krzysiek Pawlik (nelchael) wrote:
> 1.1                  www-servers/resin/resin-3.1.4.ebuild
> 
> file : 
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/www-servers/resin/resin-3.1.4.ebuild?rev=1.1&view=markup
> plain: 
> http://sources.gentoo.org/viewcvs.py/gentoo-x86/www-servers/resin/resin-3.1.4.ebuild?rev=1.1&content-type=text/plain

> src_unpack() {
> 
>       unpack ${A}
>       for i in "${WORKDIR}"/${PV}/resin-${PV}-*; do
>               epatch "${i}"
>       done;

How about:

epatch "${WORKDIR}"/${PV}/resin-${PV}-*

>       java-ant_bsfix_one "${S}/build.xml"
> 
>       sed -i -e 's/256m/384m/' "${S}/build.xml"
> 
> }

> src_compile() {
> 
>       append-flags -fPIC -DPIC

Somehow it seems wrong to append this for a whole package...

>       chmod 755 "${S}/configure"

fperms means you don't need S or quotes.

> src_install() {
> 
>       make DESTDIR="${D}" install || die

Does emake work? If not, please add a comment to that effect.

>       einfo "Fixing permissions..."
>       chown -R resin:resin "${D}${RESIN_HOME}"
>       chown -R resin:resin "${D}/etc/resin"
>       chown -R resin:resin "${D}/var/log/resin"
>       chown -R resin:resin "${D}/var/lib/resin"
>       chown -R resin:resin "${D}/var/run/resin"
> 
>       chmod 644 "${D}/etc/conf.d/resin"
>       chmod 755 "${D}/etc/init.d/resin"
>       chmod 750 "${D}/var/lib/resin"
>       chmod 750 "${D}/var/run/resin"
>       chmod 750 "${D}/etc/resin"

Again, fowners/fperms can make this a bit easier to read.

Thanks,
Donnie
-- 
[EMAIL PROTECTED] mailing list

Reply via email to