[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: java-ant-2.eclass

[Petteri Räty]

Donnie Berkholz kirjoitti:

On 21:57 Tue 22 Jan     , Petteri Raty (betelgeuse) wrote:

Revision  Changes    Path
1.26                 eclass/java-ant-2.eclass

file : 
http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/java-ant-2.eclass?rev=1.26&view=markup
plain: 
http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/java-ant-2.eclass?rev=1.26&content-type=text/plain
diff : 
http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/java-ant-2.eclass?r1=1.25&r2=1.26

@@ -262,6 +262,14 @@
                                eval xml-rewrite-2.py ${files} \
                                        -c -e ${JAVA_PKG_BSFIX_TARGET_TAGS// / 
-e } \
                                        -a nowarn -v yes ${output} || _bsfix_die 
"xml-rewrite2 failed: ${file}"
+
+                               if [[ ${JAVA_ANT_REWRITE_CLASSPATH} ]]; then
+                                       eval echo "Adding gentoo.classpath to javac 
tasks"
+                                       eval xml-rewrite-2.py ${files} \
+                                                -c -e javac -e xjavac -a 
classpath -v \
+                                                '\${gentoo.classpath}' \
+                                                || _bsfix_die "xml-rewrite2 
failed"
+                               fi
                        else
                                debug-print "Using third generation rewriter"
                                eval echo "Rewriting attributes" ${output}

What's up with all the eval use in here?

Thanks,
Donnie

Regards,
Petteri

Seems I forgot ${output} from there. Fixed now. For the xml-rewrite-2.py lines the eval could probably be dropped.

signature.asc
Description: OpenPGP digital signature