"Robin H. Johnson" <[EMAIL PROTECTED]> posted
[EMAIL PROTECTED], excerpted below, on
Thu, 21 Aug 2008 20:03:58 -0700:
> On Wed, Aug 20, 2008 at 02:57:03AM +0000, Mike Frysinger (vapier) wrote:
>> 1.1
>> sys-kernel/linux-headers/linux-headers-2.6.26.ebuild
> ...
>> src_install() {
>> kernel-2_src_install
>> cd "${D}"
>> egrep -r \
>> -e '[[:space:]](asm|volatile|inline)[[:space:](]' \ -e
>> '\<([us](8|16|32|64))\>' \
>> .
>> headers___fix $(find -type f)
>> }
> ...
>
> Are you missing a pipe after the egrep statement? What's the point of
> just spitting to stdout?
FWIW that bit's not new code; it's there in at least 2.6.25-r4 (all I
checked) as well.
This could probably do with a comment/echo/einfo saying such, but it
appears to me that the egrep is simply informational/debugging, as the
fix__headers call (function inherited from kernel-2.eclass) appears to
ultimately deal with the same list, after a bit of additional filtering
of the list of regular files fed into it from find.
(I investigated since I had the package in my updates today and after
seeing the comment here, wanted to ensure it wasn't potentially
destabilizing typo.)
--
Duncan - List replies preferred. No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master." Richard Stallman
