On Tue, Sep 23, 2008 at 4:21 PM, Bo Ørsted Andresen <[EMAIL PROTECTED]> wrote:
> On Tuesday 23 September 2008 21:39:52 Thomas Sachau wrote:
>> default_src_install() {
>> if [ -f Makefile -o -f GNUmakefile -o -f makefile ]; then
>> if emake DESTDIR="${D} install || einstall ; then
>> die "install failed"
>> else
>> if [[ -n ${DOCS} ]]; then
>> dodoc ${DOCS} || die "dodoc failed"
>> fi
>> fi
>> fi
>> }
>>
>> Any more comments? Good? Bad? Interested?
>
> Now figure out the four flaws in the above code.
Why not be helpful and point them out?
I would call your comment 'UnGentooey', if I may use a work term. I
don't think saying there are flaws in a given piece of code is really
helpful to anyone.
-Alec
>
> --
> Bo Andresen
>
