On Sun, Oct 26, 2008 at 01:36:29PM -0400, Thomas Anderson wrote:
> On Sun, Oct 26, 2008 at 05:22:26PM +0000, Greg Kroah-Hartman (gregkh) wrote:
> > # Copyright 1999-2008 Gentoo Foundation
> > # Distributed under the terms of the GNU General Public License v2
> > # $Header: /var/cvsroot/gentoo-x86/net-misc/bti/bti-007.ebuild,v 1.1
> > 2008/10/26 17:22:26 gregkh Exp $
> >
> > RDEPEND="${DEPEND}"
> >
> > src_compile() {
> > emake || die "emake failed"
> > }
> This is the default src_compile.
Ah, thanks, I should just drop this then.
> > src_install() {
> > doman bti.1
> > dobin bti
> > dodoc bti.example README RELEASE-NOTES
> > }
> You really should have some or all of these functions die on failure.
Why would any of these fail if the src_compile succeeded?
And, for some reason I thought that the default was that if there was an
error in them, they would "die" on their own. Is that not the case?
> Since that's all the ebuild installs, the package is completely
> nonfunctional if bti is not installed(I'd die on all three but you don't
> have to die on the last one).
Might as well be consistent :)
thanks for the review,
greg k-h
