On 20:49 Sun 02 Nov     , Donnie Berkholz wrote:
> On 00:08 Mon 03 Nov     , Peter Alfredsen wrote:
> > +case "${EAPI}" in
> > +   2)
> > +           EXPORT_FUNCTIONS src_unpack src_prepare src_configure 
> > src_compile src_install
> > +           ;;
> > +   *)
> > +           EXPORT_FUNCTIONS src_unpack src_compile src_install
> > +           ;;
> > +esac
> > +
> 
> This eclass needs to do the same thing as the other eclasses that got 
> EAPI=2 patches and default EAPI to 0 when it's not defined, everywhere 
> where it tests the value of EAPI.

Yeah, I realize it might technically work, but it's just asking for 
breakage in my opinion. Better to be explicit and have the '*' case be 
for something unexpected instead of an expected case.

-- 
Thanks,
Donnie

Donnie Berkholz
Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

Attachment: pgpOp3iAdqqL7.pgp
Description: PGP signature

Reply via email to