>>>>> On Thu, 19 Feb 2009, Christian Faulhammer wrote:

>> > +# The bzr command to get the diff output.
>> > +EBZR_DIFF_CMD="bzr diff"
>> 
>> > +          ${EBZR_DIFF_CMD} | diffstat
>> 
>> Why does this need to happen? Please add a comment.

>  It produces Git-like output about how much has changed. I added a
> comment to the overlay.

So it is just informational output and the dependency on
dev-util/diffstat is not essential.

pva has suggested on IRC that diffstat should only be called if it is
present. I think this is a good idea.

-DEPEND=">=dev-util/bzr-1.5
-    dev-util/diffstat"
+DEPEND=">=dev-util/bzr-1.5"

-        ${EBZR_DIFF_CMD} | diffstat
+        [ -x /usr/bin/diffstat ] && ${EBZR_DIFF_CMD} | /usr/bin/diffstat

Ulrich

Reply via email to