On 04-04-2009 18:49:50 -0600, Ryan Hill wrote:
> > +   # killing these two on OSX/Intel will disable SSE, resulting in failing
> > +   # compilations, as the headers expect SSE to be enabled (Apple knows 
> > what
> > +   # hardware they run on afterall, don't they?)
> > +   [[ ${CHOST} == i?86-apple-darwin* ]] \
> > +           && ALLOWED_FLAGS="${ALLOWED_FLAGS} -march=prescott 
> > -march=nocona"
> >  
> 
> Why do these have to be specifically included?  Aren't they handed by 
> 
>   34         export ALLOWED_FLAGS="${ALLOWED_FLAGS} -O -O0 -O1 -O2 -mcpu 
> -march -mtune"

Looking at the current code, it can't even work properly.  Even in the
case when ALLOWED_FLAGS is already set.

        if [[ -z ${ALLOWED_FLAGS} ]] ; then
                        export ALLOWED_FLAGS="-pipe"
                        export ALLOWED_FLAGS="${ALLOWED_FLAGS} -O -O0 -O1 -O2 
-mcpu -march"

Weird enough, it /did/ enable compilations to succeed in the past, but
it just can't in the current eclass, so it's bogus, and I will remove it
again.

Thanks for the check, much appreciated!


-- 
Fabian Groffen
Gentoo on a different level

Reply via email to