On 01/17/2010 11:12 PM, David Leverton wrote: > On Sunday 17 January 2010 20:38:48 Petteri Räty wrote: >> With GLEP 42 and proper logging of e* messages I think we shouldn't >> annoy users any more with ebeep or epause so attached is a patch only >> defines these functions for EAPIs 0, 1 and 2. Anyone have a reason to >> keep these around for EAPI 3? If not I will apply the attached patch. > > The eclass-manpages comments should be updated too. >
Updated patch. Will commit Wednesday unless there are objections. Regards, Petteri
@@ -19,13 +19,15 @@
DESCRIPTION="Based on the ${ECLASS} eclass"
+if has "${EAPI:-0}" 0 1 2; then
+
# @FUNCTION: epause
# @USAGE: [seconds]
# @DESCRIPTION:
# Sleep for the specified number of seconds (default of 5 seconds). Useful
when
# printing a message the user should probably be reading and often used in
# conjunction with the ebeep function. If the EPAUSE_IGNORE env var is set,
-# don't wait at all.
+# don't wait at all. Defined in EAPIs 0 1 and 2.
epause() {
[[ -z ${EPAUSE_IGNORE} ]] && sleep ${1:-5}
}
@@ -36,7 +38,7 @@
# Issue the specified number of beeps (default of 5 beeps). Useful when
# printing a message the user should probably be reading and often used in
# conjunction with the epause function. If the EBEEP_IGNORE env var is set,
-# don't beep at all.
+# don't beep at all. Defined in EAPIs 0 1 and 2.
ebeep() {
local n
if [[ -z ${EBEEP_IGNORE} ]] ; then
@@ -49,6 +51,8 @@
fi
}
+fi
+
signature.asc
Description: OpenPGP digital signature
