On 17.2.2010 16.33, Torsten Veller wrote:
>
>> --- eutils.eclass 15 Feb 2010 02:10:39 -0000 1.330
>> +++ eutils.eclass 17 Feb 2010 14:13:16 -0000
>> @@ -50,6 +50,15 @@
>> done
>> fi
>> }
>> +else
>> + ebeep() {
>> + eqawarn "ebeep is not defined in EAPI=3, please file
>
> The problem here is that eqawarn isn't defined in EAPI 3.
>
Just shows that committing things to central eclasses without review is
a bad thing. I improved the code so that it doesn't at least call
eqawarn without first checking if it exists. Instead of code like this
in the eclasses, I think this should be done by Portage grepping logs. I
think it's already running searches over it for gcc things any way.
Regards,
Petteri
betelge...@pena /usr/portage/eclass $ cvs diff eutils.eclass
Index: eutils.eclass
===================================================================
RCS file: /var/cvsroot/gentoo-x86/eclass/eutils.eclass,v
retrieving revision 1.332
diff -u -r1.332 eutils.eclass
--- eutils.eclass 17 Feb 2010 02:22:43 -0000 1.332
+++ eutils.eclass 17 Feb 2010 17:10:00 -0000
@@ -54,11 +54,13 @@
else
ebeep() {
- eqawarn "QA Notice: ebeep is not defined in EAPI=3, please file a bug
at http://bugs.gentoo.org";
+ [[ $(type -t eqawarn) == function ]] && \
+ eqawarn "QA Notice: ebeep is not defined in EAPI=3, please file
a bug at http://bugs.gentoo.org";
}
epause() {
- eqawarn "QA Notice: epause is not defined in EAPI=3, please file a bug
at http://bugs.gentoo.org";
+ [[ $(type -t eqawarn) == function ]] && \
+ eqawarn "QA Notice: epause is not defined in EAPI=3, please
file a bug at http://bugs.gentoo.org";
}
fi
