On 02/26/10 22:01, Samuli Suominen wrote: > On 02/26/2010 10:49 PM, Patrick Lauer (patrick) wrote: >> patrick 10/02/26 20:49:19 >> >> Modified: ChangeLog >> Added: samhain-2.6.2.ebuild >> Log: >> Bump >> (Portage version: 2.2_rc63/cvs/Linux x86_64) >> Index: samhain-2.6.2.ebuild >> =================================================================== >> # Copyright 1999-2010 Gentoo Foundation >> # Distributed under the terms of the GNU General Public License v2 >> # $Header: >> /var/cvsroot/gentoo-x86/app-forensics/samhain/samhain-2.6.2.ebuild,v 1.1 >> 2010/02/26 20:49:18 patrick Exp $ >> >> KEYWORDS="~amd64 ~x86" >> DESCRIPTION="Advanced file integrity and intrusion detection tool." >> HOMEPAGE="http://la-samhna.de/samhain/" >> SRC_URI="http://la-samhna.de/archive/samhain_signed-${PV}.tar.gz" >> LICENSE="GPL-2" >> SLOT="0" >> IUSE="crypt debug login-watch mounts-check mysql netclient netserver >> postgres prelude static suidcheck userfiles xml" >> >> RESTRICT="strip" > > Why restricting strip on source based package? It's wrong, at least if > it's to supress QA warnings from Portage. It only hides them.
If that's your largest criticism ... ;) This ebuild is in a rather sorry state, and no one has found the motivation to just package.mask it. Of course you're right, that RESTRICT shouldn't be there (and I have no idea how that came to happen) - ChangeLog mentions: 02 Jul 2007; Piotr Jaroszy<C5><84>ski <pe...@gentoo.org> samhain-2.1.3.ebuild, samhain-2.2.0.ebuild: (QA) RESTRICT clean up. where this happened: -RESTRICT="nostrip" +RESTRICT="strip" Impressive. And will be fixed very soonish. I hope. Sigh :) >> make || die "compile failed" >> } >> >> src_install() { >> make DESTDIR="${D}" install || die "make install failed" > > Use emake instead of make. >