On Fri, 02 Apr 2010 19:45:44 +0100 Krzysztof Pawlik <[email protected]> wrote:
> On 03/24/10 11:28, Michał Górny wrote:
> > 3. ESCM_LIVE_FAIL_IF_REPO_NOT_UPDATED (similar to the one in
> > git.eclass)
> > - a common switch to force unpack() phase to fail if no updates
> > were found during the pull/update.
>
> What about ESCM_REVISION defaulting to empty value meaning to use
> head/tip/etc revision?
ESCM_* variables would rather be set on a global basis (in make.conf or
calling env), not in specific ebuild.
> > b) Common eclass-specific variables - these ones should allow user
> > to override above variables for single SCM.
> >
> > 1. E*_STORE_DIR (defaulting to ${ESCM_DISTDIR}/*-src)
> > - already used by few eclasses, allowing user to change
> > the location where SCM-specific clones are stored.
>
> Is it really necessary? Can't we switch to one, common vcs-src/ (or
> something like this) directory?
I don't see any real benefits of using single directory, and we would
either have to move all existing repos (which would break backwards
compat and will probably have at least one serious issues) or force
user to refetch all of them. Just after a month or two ago shklee had
to it anyway due to changes in git.eclass.
> > 2. E*_OFFLINE (defaulting to ${ESCM_OFFLINE})
> > - allowing user to override global 'offline switch'. Thus, it
> > should also support setting 'false' value to enable network
> > interaction for single SCM.
>
> If there's a ESCM_OFFLINE is it necessary to copy the information
> again to vcs-specific eclasses? I don't think so. In other words: I
> don't think that copying variables from parent eclass to vcs-specific
> one has any point.
True. But this particular var is already defined in few eclasses, and I
really do not want to break compat.
And last of all, as I should have mentioned earlier, I would like
to avoid raising a revolution. I would rather like developing some
common feature list based on what eclasses currently do, and adding
missing ones to particular eclasses.
--
Best regards,
Michał Górny
<http://mgorny.alt.pl>
<xmpp:[email protected]>
signature.asc
Description: PGP signature
