On Tue, 8 Jun 2010 18:44:55 -0400
Mike Frysinger <[email protected]> wrote:

> On Sunday, June 06, 2010 03:45:51 Michał Górny wrote:
> > Well, I've already covered one corner case myself, which is the zpaq
> > ebuild. I would approve a comment on my idea here:
> > 
> > http://overlays.gentoo.org/proj/sunrise/changeset/10641/sunrise/app-arch/zp
> > aq/zpaq-1.10.ebuild
> > 
> > The hard part was that zpaq.cpp had to be compiled to both the
> > execu- table and the stub object file (with additional -DOPT flag).
> > 
> > I've decided that the simplest and most fail-proof idea was to
> > create an additional source file, defining 'OPT' and including the
> > real code, and compiling all of that within a single 'emake' call.
> 
> C/C++ files should always have a newline at the end ... that stub
> file is currently missing one.

Noted.

> i dont know anything about zpaq, but it looks like you're installing
> the bare .o files ?  that's a bit odd.  usually things like this are
> installed as static archives for people to link in ...

A single .o file exactly. ZPAQ in runtime can 'optimize' itself through
creating compression scheme sources and calling 'zpaqmake' to compile
it.

The default 'zpaqmake.bat' included with it compiled these schemes
along with 'zpaq.cpp' for the executable stub. I've decided that it'd
be better to provide already compiled stub.

Honestly, I didn't think long about the format. I guess .a could be
better, or maybe even a shared library -- but GNU make doesn't seem to
have implicit rules for these formats.

-- 
Best regards,
Michał Górny

<http://mgorny.alt.pl>
<xmpp:[email protected]>

Attachment: signature.asc
Description: PGP signature

Reply via email to