>       return 0

nowhere do you check the return value of xmms2_flag, so not much point in 
returning a value (also, the eerror path no longer returns 1)

>                       ${CHOST:+--with-target-platform=${CHOST}} \

CHOST is guaranteed to always be set, so no need for the ${VAR:+} magic

>               for option in "${option_m...@]}"; do
>               for plugin in "${plugin_m...@]}"; do

you didnt declare option/plugin local anywhere that i can see
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to