On Sat, Aug 14, 2010 at 03:35:34PM +0300, Alexis Ballier wrote:
> On Saturday 07 August 2010 00:21:39 Markos Chandras (hwoarang) wrote:
> > hwoarang 10/08/06 21:21:39
> >
> > Modified: ChangeLog
> > Added: mlt-0.5.4-r1.ebuild
> > Log:
> > Respect {C,LD}FLAGS when building shared library. Bug #308873
> > (Portage version: 2.2_rc67/cvs/Linux x86_64)
>
> While fixing bugs can't be bad and I thank you for doing it, I can see a
> couple of important quality problems in this commit:
>
> - There is absolutely no reference to any patch sent upstream and I have not
> seen anything on the upstream dev ml.
Thats because I didn't. I've fixed more than 40 bug wrt LDFLAGS. Do you
expect me to subscribe to 40 different ML and send them upstream? The
patch is there, the maintainer is CC on the bug. All he has to do it to
send this damn patch to upstream. I only care
about the QA status on tree. Most of them just use my patches and
contact upstream themselves. If this doesn't apply for you just let me
know.
> - If you are not in cc of the gentoo bug nor in the herd alias, please cc
> yourself on the bug.
> - Please close the bugs, even the dupes (and apply previous point to the
> dupes
> too).
> - That way you'll be able to quickly fix (apparently, I didn't check) obvious
> mistakes [1].
> - You'll have to do a rev. bump for *FLAGS respect, please also check if you
> can avoid it by doing a version bump instead.
Well not always. If something is on ~testing then I don't think I should
"spam" the tree with revbumps. Stable users are my first priority so
unless something is on stable branch, I fix it as it is. I don't want to
version bump anything because I don't want to mess with anyones
packages. I only do QA fixing. If you have problem touching your
packages just say it
>
>
> A.
>
>
>
> [1] https://bugs.gentoo.org/show_bug.cgi?id=332523-- Markos Chandras (hwoarang) Gentoo Linux Developer Web: http://hwoarang.silverarrow.org
pgpU75OWlzyEv.pgp
Description: PGP signature
