On Thursday, September 16, 2010 14:51:39 Matti Bickel wrote:
> +#    1.6: 'x11-libs/fox:1.6'
> +#       1.7: '~x11-libs/fox-${PV}'

first line is using a tab while second is spaces.  both should be tabs.

> FOX_PV="${FOX_PV:-${PV}}"

while you're here, i'd change to:
: ${FOX_PV:=${PV}}

>       for d in ${FOX_APPS} ; do

your prepare func should declare 'd' as local

> +     if use doc && [[ -z ${FOX_COMPONENT} ]] ; then
> +             cd "${S}/doc"
>               make docs || die "doxygen error"
>       fi

should be `emake`, and better to use -C "${S}"/doc so that you dont change 
$PWD on people

> +     if ! use doc && [[ -d ${D}/usr/share/doc/${PF}/html ]] ; then
> +             rm -fr "${D}/usr/share/doc/${PF}/html"
>       fi

you dont really need the -d check as the -f option to rm will keep it from 
warning on missing dirs
use doc || rm -rf "${D}"/usr/share/doc/${PF}/html

> +     if [[ -f ${D}/usr/bin/fox-config ]] ; then
> +             mv "${D}/usr/bin/fox-config" "${D}/usr/bin/fox-${FOXVER}-config"
>       fi

seems like you would want || die here
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply via email to