On Fri, Oct 8, 2010 at 11:33 AM, Diego Petteno (flameeyes)
<[email protected]> wrote:
> flameeyes 10/10/08 15:33:13
>
> Modified: pkg_preinst.eblit
> Log:
> QA: avoid using $D when testing the just-built loader, as it might cause
> trouble when it contains colon characters; the fix is trivial.
you'd think trivial fixes wouldnt contain bugs ...
> + pushd "${D}"/$(get_libdir) 2>/dev/null
> + ./ld-*.so --library-path . ${x} > /dev/null \
> || die "simple run test (${x}) failed"
> + popd 2>/dev/null
yet another reason (strace also readily comes to mind) i keep asking
you to post fixes and/or notify maintainers (base-system/toolchain)
instead of just committing things. pushd/popd do not write to stderr.
so this change now echoes the dirs when people emerge it. plus, this
really should be outside of the loop.
-mike
