On 10/17/2010 03:58 PM, Tony Vroon (chainsaw) wrote: > chainsaw 10/10/17 12:58:02 > > Modified: dynamips-0.2.8_rc2-makefile.patch > Log: > Instill LDFLAGS respect into upstream Makefile. Closes bug #338169 by Diego > Elio "Flameeyes" Pettenò. > > (Portage version: 2.1.9.19/cvs/Linux x86_64) > > Revision Changes Path > 1.2 > app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch > > file : > http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch?rev=1.2&view=markup > plain: > http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch?rev=1.2&content-type=text/plain > diff : > http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch?r1=1.1&r2=1.2 > > Index: dynamips-0.2.8_rc2-makefile.patch > =================================================================== > RCS file: > /var/cvsroot/gentoo-x86/app-emulation/dynamips/files/dynamips-0.2.8_rc2-makefile.patch,v > retrieving revision 1.1 > retrieving revision 1.2 > diff -u -r1.1 -r1.2 > --- dynamips-0.2.8_rc2-makefile.patch 7 Aug 2009 16:40:38 -0000 1.1 > +++ dynamips-0.2.8_rc2-makefile.patch 17 Oct 2010 12:58:02 -0000 1.2 > @@ -1,6 +1,6 @@ > -diff -uNr dynamips-0.2.8-RC2.ORIG/Makefile dynamips-0.2.8-RC2/Makefile > ---- dynamips-0.2.8-RC2.ORIG/Makefile 2009-08-07 17:24:11.000000000 +0100 > -+++ dynamips-0.2.8-RC2/Makefile 2009-08-07 17:24:52.000000000 +0100 > ++ @$(CC) -o $@ $(C_OBJS) $(A_OBJS) $(LIBS) $(LDFLAGS) > ++ @$(CC) -Wall $(CFLAGS) -o $@ nvram_export.c $(LDFLAGS)
That doesn't work. LDFLAGS need to come before objects/libraries so -Wl,--as-needed is effective. That will only silently make the QA warning from Portage go away, but is still wrong. Should be right after CC instead: $(CC) $(LDFLAGS) ...
