On 23:04 Sun 14 Nov     , Justin Bronder (jsbronder) wrote:
> pkg_setup() {
>       enewgroup munge
>       enewuser munge -1 -1 /var/lib/munge munge
> }

This is kind of a strange time to run these, since then you'll end up 
with a new user and group even if the build fails or is killed. You'll 
also end up with extraneous users and groups on build servers. Does this 
user/group need to be present on the build system for some reason? I'd 
much prefer to see it in pkg_{pre,post}inst(), despite pkg_setup() being 
much more common in the tree (from a dumb grep/sort/uniq):

     74 pkg_preinst() {
    101 pkg_postinst() {
    369 pkg_setup() {

-- 
Thanks,
Donnie

Donnie Berkholz
Sr. Developer, Gentoo Linux
Blog: http://dberkholz.wordpress.com

Attachment: pgpLg0TI5fS9J.pgp
Description: PGP signature

Reply via email to