[gentoo-dev] virtualx eclass possible issue

[Paweł Hajdan, Jr.]

One of my ebuilds is using virtualx eclass, and I noticed the following
code inside the eclass:

        retval=$?

        # Now kill Xvfb
        kill $(cat /tmp/.X${XDISPLAY}-lock)
    else
        debug-print "${FUNCNAME}: attaching to running X display"
        # Normal make if we can connect to an X display
        debug-print "${FUNCNAME}: ${VIRTUALX_COMMAND} \"$@\""
        ${VIRTUALX_COMMAND} "$@"
        retval=$?
    fi

    # die if our command failed
    [[ $? -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND} failed."

Shouldn't that last line look more like this (notice $retval instead of $?):

    [[ $retval -ne 0 ]] && die "${FUNCNAME}: the ${VIRTALX_COMMAND} failed."

What do you think?

signature.asc
Description: OpenPGP digital signature