> # @BLURB: Use this to easy install EMBOSS and EMBASSY programs (EMBOSS
> add-ons).
do those need to be capitalized ? if upstream refers to them as
EMBOSS and EMBASSY, then i guess it makes sense ...
> # ebuild Variables can be extended (FOO+=" bar").
variables
> # Example:
> ...
> # KEYWORDS="~amd64 ~ppc ~x86 ~amd64-linux ~x86-linux ~ppc-macos"
not sure this makes sense in the example
> # @ECLASS-VARIABLE: EBO_EAUTORECONF
> # @DESCRIPTION:
> # Set to 'no', if you don't want eautoreconf to be run after patching.
isnt the opposite behavior the desired default ? generally running
autotools is undesirable ...
> : ${EBO_EAUTORECONF:="yes"}
no need for quotes
> inherit autotools eutils multilib
i dont see multilib being used anywhere
> DEPEND="
> dev-libs/expat
> ....
> RDEPEND="${DEPEND}"
usually DEPEND is a superset of RDEPEND, so might make more sense to
reverse these. not that it really matters.
> S="${WORKDIR}"/${EF}
no need for quotes
> [[ -f "${FILESDIR}"/${PF}.patch ]] && epatch "${FILESDIR}"/${PF}.patch
no need for quotes inside of this [[...]]
> # runs econf with following options. Extra options can be passed by setting
> EBO_EXTRA_ECONF
i'd add a "." to the end here, or just drop the 2nd sentence
altogether. you already documented EBO_EXTRA_ECONF above, and the
example shows it being used.
> --docdir="${EPREFIX}/usr/share/doc/${PF}/" \
these arent typically specified with a trailing slash
-mike
