* Mike Frysinger schrieb am 23.03.11 um 00:08 Uhr:
> 2011/3/22 Tomáš Chvátal:
> > Dne 22.3.2011 22:26, Mike Frysinger napsal(a):
> >>> # @BLURB: This eclass provides functions for fetch and unpack git 
> >>> repositories
> >>
> >> fetching/unpacking
> >
> > Yarp fixed.
> 
> well, the fix broke the blurb.  it has to be on one line.
> # @BLURB: foo
> 
> > EGIT_BRANCH=${x:-${EGIT_BRANCH:=${EGIT_MASTER}}}
> > EGIT_COMMIT=${x:-${EGIT_COMMIT:=${EGIT_BRANCH}}}
> 
> doesnt make much sense to use := ... it should be :-
> 
> > [[ "$#" -ne 1 ]] && die "${FUNCNAME}: requires 1 argument (path)"
> 
> quoting doesnt make much sense ... -ne compares an int, not a string

If using [[ you never need to quote anyway.

-Marc
-- 
8AAC 5F46 83B4 DB70 8317  3723 296C 6CCA 35A6 4134

Reply via email to