Another ruby ebuild review. Some of the issues that were present in fromcvs are also in this ebuild, I won't repeat them.
On Wed, 2011-06-15 at 22:01 +0000, Stanislav Ochotnicky (sochotnicky) wrote: > sochotnicky 11/06/15 22:01:26 > > Added: rcsparse-0_pre45.ebuild metadata.xml ChangeLog > Log: > New ebuild for rcsparse, a dependency of fromcvs > > (Portage version: 2.1.9.42/cvs/Linux x86_64) > > Revision Changes Path > 1.1 dev-ruby/rcsparse/rcsparse-0_pre45.ebuild > > file : > http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-ruby/rcsparse/rcsparse-0_pre45.ebuild?rev=1.1&view=markup > plain: > http://sources.gentoo.org/viewvc.cgi/gentoo-x86/dev-ruby/rcsparse/rcsparse-0_pre45.ebuild?rev=1.1&content-type=text/plain > > Index: rcsparse-0_pre45.ebuild > =================================================================== > # Copyright 1999-2011 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > # $Header: > /var/cvsroot/gentoo-x86/dev-ruby/rcsparse/rcsparse-0_pre45.ebuild,v 1.1 > 2011/06/15 22:01:26 sochotnicky Exp $ > > EAPI=2 > > USE_RUBY="ruby18 ree18" > > #mercurial after ruby! > inherit ruby-ng mercurial > > MY_PV="${PV#0_pre}" > > DESCRIPTION="rcsparse ruby module" > HOMEPAGE="http://ww2.fs.ei.tum.de/~corecode/hg/rcsparse"; > SRC_URI="" > EHG_REPO_URI="http://ww2.fs.ei.tum.de/~corecode/hg/rcsparse"; > EHG_REVISION="${MY_PV}" > > LICENSE="BSD-4" > SLOT="0" > KEYWORDS="~amd64" > IUSE="test" > > RUBY_S="${PN}-${PV}" > > # this is a workaround because combination of ruby-ng and mercurial is > # not working correctly for unpacking > src_prepare() { > for rubyv in ${USE_RUBY}; do > mkdir "${WORKDIR}/$rubyv" > cp -prl "${S}" "${WORKDIR}/$rubyv/${RUBY_S}" > done > } > > each_ruby_configure() { > ${RUBY} extconf.rb || die > } > > each_ruby_compile() { > emake || die > } > > each_ruby_test() { > ${RUBY} test.rb || die Don't test the already installed version: ${RUBY} -I. test.rb || die Also, depend on the test framework: ruby_add_bdepend "test? ( virtual/ruby-test-unit )" > } > > each_ruby_install() { > emake DESTDIR="${D}" install || die > }
signature.asc
Description: This is a digitally signed message part
